In addition to the finite and depleting resources the player should be also given multiple choices in which player can choose one of it.
But yah i agree with this idea like even if a town gets a resource which is OP it wont last long and it will depleted. But yah prices should be very low coz it will be hard to afford with same prices as off now again and to get re rolled.

It sounds better on paper than it actually is. There are multiple problems with this that you didnt consider.

1) Inactive towns. Inactive towns now give nations good income from towny resources and can account for about 50% or more of the towny resources generated by nations. If it depletes then those towns wont be able to get new ones

2) Average over a larger sample. While if you have bad resource it would be good to just reroll and at least get some good resources, on the nation scale nothing would change since due to random generation the total table wont change. Some town that used to have feathers now gets diamonds and diamonds now gets feathers.

3) Complexity. It already takes some time to explain to new mayors that joined the server how towny resources work, telling them to get new ones every now and then might become harder and too complex

4) Occupation. If you are occupied you can just not survey new ones so the enemy doesnt get it

Most of the towny resources arent bad items, its just that at that quantity they contribute as much as some others. The useless ones shouldnt be in the game at all

1. Instead of a limit of how many times you can collect it, a limit can be set for how long you can collect the resource for, lets say 2 weeks, its up to you if you collect resources daily or if you miss a few days, the resource will reroll after those 2 weeks.
2. Ok? It's balanced tho? It's like the poor and the rich, and now the poor get to be rich sometimes and the rich are going to be poor sometimes. That instead of 1 town getting permanent good resources and another permanent bad resources.
3. New mayors already dont bother surveying, they simply aren't to experienced to even know the feature, once they get to know it they will understand the entire feature.
4. Perhaps, but on the long term you eventually want to get some resources with your occupied town, you still get a few resources yourself so eventually occupied towns will just re-roll anyways.

I mean perhaps youre right, some items should be towny resources, but it doesn't take away the fact that I, and this is just me, wouldn't be happy with diamonds as a resource because i simply have enough of those, so you can never satisfy everyone by removing / adding certain resources, I think this suggestion is best for all

I dont mind the average if every resource is at least useful for something. I would rather have a good resource at very low amounts than feathers or spider eyes

What if it was based on region, so remaking your town wouldnt make sense, as you're only going to get the same resources anyways